fill other types of fields in searchBrowse/FilterBrowse#1890
Merged
98llm merged 1 commit intorelease/v2.6.0rc19from Apr 1, 2026
Merged
fill other types of fields in searchBrowse/FilterBrowse#189098llm merged 1 commit intorelease/v2.6.0rc19from
98llm merged 1 commit intorelease/v2.6.0rc19from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Summary
Refactors and extends the SearchBrowse/FilterBrowse functionality in PouiInternal to support multiple field types in the THF Browse filter panel.
Changes
_set_browse_filters
Removed the unused _find_search_browse() call at the start of the method.
Replaced the single hard-coded po-input filling logic with a dynamic field-type detection strategy using _identify_filter_field().
Now delegates filling to the appropriate internal method based on detected component type.
New Methods Added
Method Description
_identify_filter_field(field_label) Detects the component type (po-input, po-datepicker, po-select, thf-lookup) of a filter field by its label inside the po-page-slide panel.
_fill_input(input_element, value) Fills standard text/date input fields with retry logic and validation.
_fill_lookup_input(input_element, value) Fills thf-lookup fields by typing a value, waiting for the suggestion list, and selecting the matching item.
_get_lookup_list_item(value) Locates a matching
Motivation
Previously, SearchBrowse/FilterBrowse only supported po-input fields. This change enables filtering by date pickers, select/combo boxes, and lookup components, making the method usable across a broader range of browse screens.